| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | David Gilman <davidgilman1(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: "tuple concurrently updated" in pg_restore --jobs |
| Date: | 2020-07-10 21:36:28 |
| Message-ID: | 2164430.1594416988@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> On Fri, Jul 10, 2020 at 04:54:40PM -0400, Tom Lane wrote:
>> This works about 99% of the time, in fact. It falls down in the --clean
> Note that this fails for me (sometimes) even without --clean.
Oh, I was thinking that REVOKE would only be issued in the --clean
case, but apparently that's not so. Doesn't really affect the fix
proposal though. I just finished a patch for HEAD, as attached.
(I flushed the "CatalogId objCatId" argument of dumpACL, which was
not used.)
I'm not sure how far to back-patch it -- I think the parallel restore
of ACLs behavior is not very old, but we might want to teach older
pg_dump versions to insert the extra dependency anyway, for safety.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| make-column-ACLs-depend-on-table-ACLs-1.patch | text/x-diff | 11.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2020-07-10 21:41:38 | Re: Stale external URL in doc? |
| Previous Message | Tom Lane | 2020-07-10 21:30:41 | Re: Default setting for enable_hashagg_disk |