| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | pgsql-committers(at)postgresql(dot)org, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Subject: | Re: pgsql: Use FLEXIBLE_ARRAY_MEMBER in a bunch more places. |
| Date: | 2015-02-20 15:49:32 |
| Message-ID: | 21635.1424447372@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> This triggers a large number of warnings with my preexisting clang 3.6 settings...
> In file included from /home/andres/src/postgresql/src/backend/postmaster/pgstat.c:40:
> /home/andres/src/postgresql/src/include/catalog/pg_proc.h:61:12: warning: 'proargtypes' may not be nested in a struct due to flexible array
That's annoying. I saw that Sun Studio was complaining similarly, but
I figured we could ignore it.
It's weird that compiler writers have such a hard time understanding
what actually counts as a *useful* warning, ie "you've got a flexible
array embedded in the middle of a bigger struct". Instead we get
either nothing (gcc) or pedantry (this).
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-02-20 16:01:21 | pgsql: Update PGSTAT_FILE_FORMAT_ID |
| Previous Message | Tom Lane | 2015-02-20 15:46:40 | Re: pgsql: Use FLEXIBLE_ARRAY_MEMBER in a bunch more places. |