| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Joe Conway <mail(at)joeconway(dot)com> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: Getting rid of "unknown error" in dblink and postgres_fdw |
| Date: | 2016-12-21 17:27:31 |
| Message-ID: | 21630.1482341251@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Joe Conway <mail(at)joeconway(dot)com> writes:
> On 12/21/2016 08:49 AM, Tom Lane wrote:
>> I propose that we should change that string to "could not obtain message
>> string for error on connection "foo"", or something along that line.
>>
>> postgres_fdw has the same disease. It wouldn't have the notion of a named
>> connection, but maybe we could insert the foreign server name instead.
> Seems reasonable to me. I can work on it if you'd like. Do you think
> this should be backpatched?
If you have time for it, please do, I have lots on my plate already.
I'd vote for back-patching; the benefits of a clearer error message
are obvious, and it hardly seems likely that any existing applications
are depending on this specific error string.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2016-12-21 17:34:01 | Re: [BUG?] pg_event_trigger_ddl_commands() error with ALTER TEXT SEARCH CONFIGURATION |
| Previous Message | Robert Haas | 2016-12-21 17:23:16 | Re: WAL consistency check facility |