| From: | "Joel Jacobson" <joel(at)compiler(dot)org> |
|---|---|
| To: | "jian he" <jian(dot)universality(at)gmail(dot)com> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: New "single" COPY format |
| Date: | 2024-12-19 10:17:12 |
| Message-ID: | 216005e5-dda1-4b46-859f-e9f235d4b5df@app.fastmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 19, 2024, at 07:48, jian he wrote:
> I have reviewed v21-0001 again.
>
> v21-0001-Introduce-CopyFormat-and-replace-csv_mode-and-binary.patch
> is a good refactor.
>
>
> overall looks good to me.
OK, I could submit it as a separate patch.
Would we also want the reorganization of existing copy option validations?
That is, v21-0003-Reorganize-option-validations.patch minus v21-0002-Add-COPY-format-list.patch.
Nice that you managed to arrange them in the same order as in the documentation. Made the code easier to follow.
/Joel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Emanuele Musella | 2024-12-19 10:22:02 | Re: Parametrization minimum password lenght |
| Previous Message | Andrey Borodin | 2024-12-19 10:10:09 | Re: Fix bank selection logic in SLRU |