| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Philip Semanchuk <philip(at)americanefficient(dot)com> |
| Cc: | Dave Page <dpage(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #16279: Permissions doc incorrect for pg_buffercache |
| Date: | 2020-02-27 21:31:34 |
| Message-ID: | 21597.1582839094@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Philip Semanchuk <philip(at)americanefficient(dot)com> writes:
> On Feb 26, 2020, at 12:11 PM, Sergei Kornilov <sk(at)zsrv(dot)org> wrote:
>> You are right, in contrib/pg_buffercache/pg_buffercache--1.2--1.3.sql we have
>> GRANT EXECUTE ON FUNCTION pg_buffercache_pages() TO pg_monitor;
>> GRANT SELECT ON pg_buffercache TO pg_monitor;
>> Not pg_read_all_stats. I'm not sure: we need change the extension or fix the documentation? I think pg_read_all_stats would be more appropriate, but we need bump the extension version.
> Thanks for exploring and confirming! I agree that pg_read_all_stats would be more appropriate.
Looking at the original discussion, it seems clear that the choice of
pg_monitor was intentional; see in particular
So I think the code is correct and the documentation is a typo.
That's a much easier answer to back-patch, as well.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Philip Semanchuk | 2020-02-27 21:39:04 | Re: BUG #16279: Permissions doc incorrect for pg_buffercache |
| Previous Message | Philip Semanchuk | 2020-02-27 21:13:17 | Re: BUG #16279: Permissions doc incorrect for pg_buffercache |