| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Greg Stark <stark(at)mit(dot)edu>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP patch for consolidating misplaced-aggregate checks |
| Date: | 2012-08-14 16:04:12 |
| Message-ID: | 2157.1344960252@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Speaking of english words, I was wondering at "check" the other day.
> For example, we have
> #: catalog/heap.c:2171
> #, c-format
> msgid "check constraint \"%s\" already exists"
> #: catalog/heap.c:2534
> #, c-format
> msgid "only table \"%s\" can be referenced in check constraint"
> And so on (there are several more). Note that here we use "check
> constraint" without any capitalization.
FWIW, I think I changed "check" to "CHECK" in a couple of messages
recently, for exactly the reason that it seemed to be used in its
keyword meaning rather than as plain English text. Perhaps we
should just go around and do that consistently.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2012-08-14 17:50:07 | Re: 9.2 Cascading replication after slave promotion |
| Previous Message | Heikki Linnakangas | 2012-08-14 15:46:18 | Re: Statistics and selectivity estimation for ranges |