Re: Dead code in _bt_split?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>
Cc: "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Dead code in _bt_split?
Date: 2006-12-07 23:05:09
Message-ID: 21540.1165532709@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Heikki Linnakangas" <heikki(at)enterprisedb(dot)com> writes:
> This is right after a for-loop, which exits when i = maxoff + 1. So the
> first if-statement could be written as "if (newitemoff > maxoff)". If
> that's true, newitemonleft shouldn't be true, because that would mean
> that we've split a page so that all items went to the left page, and the
> right page is empty.

No, it would mean that we split the page in such a way that only the new
item is going to the right page. Probably not hard to duplicate if you
use near-maximal-sized keys.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2006-12-07 23:18:34 Re: Dead code in _bt_split?
Previous Message Jeff Davis 2006-12-07 22:00:40 Re: old synchronized scan patch

Browse pgsql-patches by date

  From Date Subject
Next Message Heikki Linnakangas 2006-12-07 23:18:34 Re: Dead code in _bt_split?
Previous Message Heikki Linnakangas 2006-12-07 19:32:48 Dead code in _bt_split?