Re: CVS corruption/mistagging?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Marc G(dot) Fournier" <scrappy(at)hub(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Kris Jurka <books(at)ejurka(dot)com>, pgsql-hackers(at)postgresql(dot)org, Michael Meskes <meskes(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: CVS corruption/mistagging?
Date: 2007-08-15 03:26:03
Message-ID: 21532.1187148363@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Great --- launching cvs rtag command now.

Done, and I got a plausible-looking mix of messages like
cvs rtag: Not removing branch tag `REL7_4_STABLE' from `/cvsroot/pgsql/src/tutorial/funcs_new.c,v'.
and a fresh checkout of REL7_4_STABLE now matches what I had locally.
So I think we walked away from that one.

TODO items:

* restrict, or at least log, cvs tag/rtag commands. Maybe report them
to pgsql-committers.

* I notice that the repository contains some files owned by
no-longer-existent accounts, eg 258 in contrib/btree_gist:

> ls -la
total 460
drwxrwxr-x 6 scrappy dev 1024 Aug 15 03:00 .
drwxrwxr-x 90 scrappy dev 2048 Aug 15 03:00 ..
drwxrwxr-x 2 scrappy dev 512 Apr 20 15:16 Attic
-r--r--r-- 1 tgl dev 9555 Jun 26 22:05 Makefile,v
-r--r--r-- 1 258 dev 5870 Apr 20 16:19 README.btree_gist,v
-r--r--r-- 1 tgl dev 12033 Aug 15 03:00 btree_bit.c,v
-r--r--r-- 1 tgl dev 9902 Aug 15 03:00 btree_bytea.c,v
-r--r--r-- 1 tgl dev 10227 Aug 15 03:00 btree_cash.c,v
-r--r--r-- 1 tgl dev 11414 Aug 15 03:00 btree_date.c,v
-r--r--r-- 1 tgl dev 10211 Aug 15 03:00 btree_float4.c,v
-r--r--r-- 1 tgl dev 10074 Aug 15 03:00 btree_float8.c,v
-r--r--r-- 1 tgl dev 33915 Aug 15 03:00 btree_gist.c,v
-r--r--r-- 1 258 dev 4325 Apr 20 15:16 btree_gist.h,v
-r--r--r-- 1 258 dev 58744 Apr 20 16:19 btree_gist.sql.in,v
-r--r--r-- 1 tgl dev 14717 Aug 15 03:00 btree_inet.c,v
-r--r--r-- 1 tgl dev 10234 Aug 15 03:00 btree_int2.c,v
-r--r--r-- 1 tgl dev 10221 Aug 15 03:00 btree_int4.c,v
-r--r--r-- 1 tgl dev 10235 Aug 15 03:00 btree_int8.c,v

I suppose this is due to Magnus' cleanup of unused committers accounts.
That was a good thing, but for security's sake these files ought to be
chown'd to some existing committer's account.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2007-08-15 03:38:28 Re: tsearch2 in PostgreSQL 8.3?
Previous Message Bruce Momjian 2007-08-15 03:14:35 Re: tsearch2 in PostgreSQL 8.3?