| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Bruce Momjian <bruce(at)momjian(dot)us>, "pgsql-docs(at)lists(dot)postgresql(dot)org" <pgsql-docs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_type_d.h location incorrect |
| Date: | 2021-05-29 18:31:01 |
| Message-ID: | 2150497.1622313061@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
"tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> writes:
> On Thursday, May 27, 2021 11:27 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote
>> No ... "patch -p1 <~/improve-pgservice-docs.patch" works fine for me.
> Oh, never tried "patch -p1" command before but it worked. Thanks!!
> BTW, here is my previous operation to apply your patch(failed, which is strange IMO)
> $ git apply --3way improve-pgservice-docs.patch
Yeah, "git apply" is extremely picky. I'm not sure we've ever figured out
all the reasons why it sometimes doesn't work. Good old "patch" pretty
much always works though.
> Attached a patch to combine the above fix in your patch.
> Also fixed a typo in install-windows.sgml.
> Also fixed pgbuffercache.sgml as Michael commented at [1].
LGTM, pushed with one minor additional tweak.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Emre Hasegeli | 2021-05-30 13:25:23 | Note that ALTER TABLE cannot alter generated stored columns |
| Previous Message | tanghy.fnst@fujitsu.com | 2021-05-28 02:50:48 | RE: pg_type_d.h location incorrect |