Re: 'pg_ctl -w' times out when unix_socket_directory is

Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> I have attached a patch. I wrote it very quickly, but it seems to work
> as I expect.

I don't think this is very workable as a postgresql.conf parser ...
at minimum it needs to handle quoted strings correctly, and really it
ought to deal with file inclusions.

There are other reasons why pg_ctl needs to look at
postgresql.conf --- it currently fails to cope with
config-file-outside-the-datadir cases, and that can't be fixed except by
extracting the data_directory setting from the config file. What we
probably need to do is port guc-file.l into the pg_ctl environment.
(Not sure if it's feasible to use a single source file for both cases,
though that would be nice if not too messy.)

regards, tom lane