From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Thomas Lockhart <lockhart(at)alumni(dot)caltech(dot)edu> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: [HACKERS] NUMERIC type conversions leave much to be desired |
Date: | 1999-05-09 16:04:04 |
Message-ID: | 2145.926265844@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thomas Lockhart <lockhart(at)alumni(dot)caltech(dot)edu> writes:
> OK, and while I was looking at it I noticed that the T_Integer code
> didn't bother using the int4out() routine to generate a string. imho
> it should be using the official output routine unless there is some
> compelling reason not to. It seems to still behave with this fix in
> the T_Integer support code; should I commit both?
One potential problem is that if the value is large/small enough to make
float8out use 'E' notation, conversion to numeric will still fail ---
this is the same problem you hacked around in float8_numeric() earlier.
I still like the idea of hanging on to the original string form of the
constant long enough so that parser_typecast can feed that directly to
the target type's xxx_in() routine, and not have to worry about
conversion errors.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Lockhart | 1999-05-09 16:53:55 | Re: [HACKERS] Niladic functions |
Previous Message | Bruce Momjian | 1999-05-09 16:03:57 | Re: [HACKERS] Niladic functions |