Re: pgsql: Add functions pg_set_attribute_stats() and pg_clear_attribute_st

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Davis <jdavis(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add functions pg_set_attribute_stats() and pg_clear_attribute_st
Date: 2024-10-23 03:18:34
Message-ID: 2144895.1729653514@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Jeff Davis <jdavis(at)postgresql(dot)org> writes:
> Add functions pg_set_attribute_stats() and pg_clear_attribute_stats().

A couple of buildfarm animals, eg [1], are mildly unhappy:

In file included from ../../../src/include/nodes/execnodes.h:37:0,
from ../../../src/include/catalog/indexing.h:19,
from attribute_stats.c:21:
attribute_stats.c: In function \342\200\230text_to_stavalues\342\200\231:
../../../src/include/nodes/miscnodes.h:54:15: warning: the comparison will always evaluate as \342\200\230true\342\200\231 for the address of \342\200\230escontext\342\200\231 will never be NULL [-Waddress]
((escontext) != NULL && IsA(escontext, ErrorSaveContext) && \\
^
attribute_stats.c:636:6: note: in expansion of macro \342\200\230SOFT_ERROR_OCCURRED\342\200\231
if (SOFT_ERROR_OCCURRED(&escontext))
^

I think what we've done in other places is just to test
escontext.error_occurred directly, since the rest of the
macro is useless in this situation.

regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=rhinoceros&dt=2024-10-23%2000%3A47%3A26&stg=make

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Pavel Borisov 2024-10-23 06:01:49 Re: pgsql: Implement pg_wal_replay_wait() stored procedure
Previous Message Michael Paquier 2024-10-22 23:35:51 pgsql: ecpg: Fix out-of-bound read in DecodeDateTime()