Re: pgsql: Add pg_noinline macro to c.h.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add pg_noinline macro to c.h.
Date: 2017-10-13 22:32:08
Message-ID: 21403.1507933928@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)anarazel(dot)de> writes:
> Add pg_noinline macro to c.h.

I think you want this to be parenthesized so that pgindent doesn't
go nuts when you use it. At least, that was the reason why
pg_attribute_noreturn() has parens. Even if the current version
of pgindent doesn't have that problem, I would argue that consistency
demands that you spell this pg_attribute_noinline().

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2017-10-13 22:43:46 Re: pgsql: Add pg_noinline macro to c.h.
Previous Message Andres Freund 2017-10-13 21:29:03 pgsql: Add pg_noinline macro to c.h.