Re: [HACKERS] samekeys

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
Cc: hackers(at)postgreSQL(dot)org (PostgreSQL-development)
Subject: Re: [HACKERS] samekeys
Date: 1999-02-09 16:04:47
Message-ID: 2140.918576287@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> writes:
> This basically says that key1, which is the old key, has to match key2
> for the length of key1. If key2 has extra keys after that, that is
> fine. We will still consider the keys equal. The old code obviously
> was broken and badly thought out.
> ...
> I am unsure if samekeys should just test the first key for equality, or
> the full length of key1 as I have done.

The comment in front of samekeys claimed:

* It isn't necessary to check that each sublist exactly contain
* the same elements because if the routine that built these
* sublists together is correct, having one element in common
* implies having all elements in common.

Was that wrong? Or, perhaps, it was once right but no longer?
It sounded like fragile coding to me, but I didn't have reason
to know it was broken...

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 1999-02-09 16:26:01 Re: [HACKERS] v6.4.3 ?
Previous Message Thomas G. Lockhart 1999-02-09 15:52:47 Re: RES: [HACKERS] Timestamp fileds into index