| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | "Sisson, David" <David(dot)Sisson(at)dell(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #17757: Not honoring huge_pages setting during initdb causes DB crash in Kubernetes |
| Date: | 2023-01-23 22:51:46 |
| Message-ID: | 2139743.1674514306@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Andres Freund <andres(at)anarazel(dot)de> writes:
> It's a fault of the environment if mmap(MAP_HUGETLB) causes a SIGBUS. Normally
> huge_pages = try is harmless, because it'll just fall back. That source of
> SIGBUSes needs to be fixed regardless of anything else - plenty allocators try
> to use huge pages for example, so you'll run into problems regardless of
> postgres' default.
That seems likely to me too.
> That said, I'm for allowing to specify options to initdb.
Yeah, I think that has enough other potential applications to be worth
doing. Here's a quick draft patch (sans user-facing docs as yet).
It injects any given values into postgresql.auto.conf, not
postgresql.conf proper. I did that mainly because the latter looked
beyond the abilities of the primitive string-munging code we have in
there, but I think it can be argued to be a reasonable choice anyway.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| override-config-options-during-initdb-0.1.patch | text/x-diff | 8.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-01-24 00:37:37 | Re: BUG #17757: Not honoring huge_pages setting during initdb causes DB crash in Kubernetes |
| Previous Message | Sam.Mesh | 2023-01-23 22:46:59 | Re: index not used for bigint without explicit cast |