Re: hashing bpchar for nondeterministic collations is broken

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Richard Guo <guofenglinux(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: hashing bpchar for nondeterministic collations is broken
Date: 2022-12-02 21:49:16
Message-ID: 2137318.1670017756@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> But assuming someone does use that combination of features in 15.1, and
> we release 15.2 with my fix in it, then the consequences could be
> severe: a pg_dump with default options on their bpchar-
> nondeterministic-collation-hash-partitioned table in 15.1 would be
> unrestorable in 15.2. They'd need to take a new pg_dump from 15.1 with
> "--load-via-partition-root" and then restore it in 15.2. Obviously that
> would be bad in any case, but it's more tolerable going between servers
> of different major versions.

Yeah. Also, do we have this issue with hash indexes? If so
reindexing might be necessary, which again would be more
palatable in a major release.

> So, given that this fix is unlikely to help many people in 15 and
> earlier, and that there's a chance that the fix is really painful for
> someone; I'm electing not to backpatch it.

+1

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Jeff Davis 2022-12-02 22:04:30 Re: hashing bpchar for nondeterministic collations is broken
Previous Message Jeff Davis 2022-12-02 21:21:08 Re: hashing bpchar for nondeterministic collations is broken