| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Missing PG_INT32_MIN in numutils.c |
| Date: | 2016-04-13 14:11:30 |
| Message-ID: | 21344.1460556690@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, Apr 13, 2016 at 9:38 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I am not very convinced that this is an improvement, because you took
>> what had been two hard-wired constants and replaced them with a symbol
>> and a hard-wired constant.This is more prone to break, not less so.
> I think it's kind of six of one, half a dozen of the other, but if you
> feel strongly about it, revert the patch.
I don't care enough to do that either, but I wanted to point out that
it's pretty questionable whether this is a stylistic improvement.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | José Luis Tallón | 2016-04-13 14:11:45 | Re: Parser extensions (maybe for 10?) |
| Previous Message | Robert Haas | 2016-04-13 14:11:06 | Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |