Re: reloptions with a "namespace"

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Khee Chin <kheechin(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: reloptions with a "namespace"
Date: 2009-04-03 20:11:52
Message-ID: 21306.1238789512@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Tom Lane escribi:
>> Surely this will break other things. I find myself wondering why you
>> invented ReloptElem at all, instead of adding a field to DefElem.

> I had to, precisely because it messes up other uses of DefElem ...

> For example, the grammar would allow
> CREATE FUNCTION ... WITH something.name = value
> which we certainly don't want.

Well, you could still have separate productions that did or didn't allow
qualified names there (or perhaps better, have the code in
functioncmds.c reject qualified names). I think the use of two different
node types is going to result in duplicate coding and/or bugs deeper in
the system, however.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2009-04-03 20:15:10 Re: a few crazy ideas about hash joins
Previous Message Alvaro Herrera 2009-04-03 20:06:47 Re: reloptions with a "namespace"