| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Subject: | Re: PATCH: Update snowball stemmers |
| Date: | 2018-09-12 21:47:05 |
| Message-ID: | 21238.1536788825@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> writes:
> On Wed, Sep 12, 2018 at 04:03:57PM -0400, Tom Lane wrote:
>> Did you miss including Makefile changes in the submitted patch?
> I've noticed the error some time ago. And I tried to understand why
> cfbot can't build it. Somehow cfbot didn't rename
> stem_ISO_8859_1_hungarian. You can see it from the commit [1]. And there
> is no new file stem_ISO_8859_2_hungarian.c [2].
Oh, patch(1) doesn't understand git's idea of "renaming" files, cf
I'd suggest using "git diff --no-renames", since some of us will want
to apply the patch using patch(1).
> In my laptop there is no such problem. I tried both "git apply" and
> "patch -p1". And I can build the patch.
Really? What version of patch was that?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-09-12 21:48:30 | Re: Re[3]: doc - improve description of default privileges |
| Previous Message | Bradley DeJong | 2018-09-12 21:45:19 | Re[3]: doc - improve description of default privileges |