Re: Additional system indexes

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom, you mentioned you needed more system indexes. I would be glad to
> create them for you. Can you tell me which ones?

Let's see, we need an index on pg_index's indrelid column (non unique
of course). Offhand I do not know of any others. I would like to get
*rid* of the index(es) on pg_listener and revert async.c to its index-
free state; it seems unlikely that indexes on pg_listener will be worth
their maintenance effort.

Another idea that had come up in that thread was to get rid of
pg_attrdef completely and put its info into two new columns in
pg_attribute. Not sure if anyone but me thought that'd be worth
the trouble.

> Also, I see a heap_getnext on pg_attribute in vacuum.c that should be
> using index scan. Are there other places in the code where this needs
> to be changed?

Dunno; I haven't had time to go looking for suspicious heap_getnext
loops.

Another thing we had discussed was to try to unify the APIs of the
heap_getnext and index_getnext routines so that it could be fairly
transparent in calling code which one you are using. That'd allow
support of Hiroshi's disable-system-indexes feature without so much
cruft. If we are going to do that, it probably ought to happen before
we start adding more call sites that'll have to be fixed.

regards, tom lane