| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: cache lookup failed for collation 0 |
| Date: | 2019-04-11 17:20:41 |
| Message-ID: | 21216.1555003241@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> writes:
> Do you mean, the code in get_collation_isdeterministic() should look like
> something like below?
> If colloid = InvalidOid then
> return TRUE
> ELSE IF tuple is valid then
> return collisdeterministic from the tuple
> ELSE
> return FALSE
I think it's appropriate to fail if we don't find a tuple, for any
collation oid other than zero. Again, if you trace through the
behavior of the longstanding collation check functions like
lc_ctype_is_c(), you'll see that that's what happens (except for
some hardwired OIDs that they have fast paths for).
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-04-11 17:27:03 | Re: setLastTid() and currtid() |
| Previous Message | Robert Haas | 2019-04-11 17:11:36 | Re: Pluggable Storage - Andres's take |