Re: What to do with inline warnings?

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> What do we do with warnings generated by -Winline?

I believe we just put that in to see how many places inlining was being
done or not. If you want to compile with -Werror you'd better take it out.

> tqual.c: In function HeapTupleSatisfiesVacuum:
> tqual.c:88: error: inlining failed in call to SetHintBits: call is unlikely and code size would grow
> tqual.c:1057: error: called from here
> tqual.c:88: error: inlining failed in call to SetHintBits: call is unlikely and code size would grow
> tqual.c:1061: error: called from here

Hmm, it's a bit disturbing that the compiler is taking it upon itself to
decide that these calls are "unlikely".

regards, tom lane