| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>, Michael Meskes <meskes(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Move strtoint() to common |
| Date: | 2018-03-16 02:37:06 |
| Message-ID: | 21199.1521167826@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Thu, Mar 15, 2018 at 06:57:27PM -0400, Tom Lane wrote:
>> I think what's wrong is that src/tools/msvc/ecpg_regression.proj
>> needs to be taught that tests under ecpg/test/compat-oracle need
>> to be run with "-C ORACLE". Neither that directory nor that
>> switch existed before yesterday. There's already stuff in there
>> that knows about "-C INFORMIX", but beyond seeing the switch it
>> looks like line noise to me, so I'm not volunteering to fix it.
> I can confirm that commit 3b7ab43 is at fault, that I can see the
> failure, and that the patch attached fixes the failure.
Seems sane AFAICT, so pushed. Thanks!
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-03-16 02:42:36 | Re: pgsql: Move strtoint() to common |
| Previous Message | Tom Lane | 2018-03-16 02:36:23 | pgsql: Fix msvc/ecpg_regression.proj for recent ECPG test additions. |