Re: slru bank

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: 席冲(宜穆) <xichong(dot)xc(at)alibaba-inc(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: slru bank
Date: 2024-08-23 02:27:42
Message-ID: 2116449.1724380062@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
> On Thu, Aug 22, 2024 at 7:07 PM 席冲(宜穆) <xichong(dot)xc(at)alibaba-inc(dot)com> wrote:
>> In SlruSelectLRUPage(), Why do we need to traverse all slots to find that
>> a page already has a buffer assigned? Why not find it
>> from the [bankstart,bankend]?

> Only the bank is searched, both of the logic loops are bounded by:
> for (int slotno = bankstart; slotno < bankend; slotno++)

I think the OP has rediscovered the bug already fixed in 7b063ff26.
That's post-17beta2, though.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2024-08-23 02:31:14 Re: Redundant Result node
Previous Message David G. Johnston 2024-08-23 02:19:35 Re: slru bank