| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Greg Stark <gsstark(at)mit(dot)edu>, Jaime Casanova <jaime(at)2ndQuadrant(dot)com>, Gabriele Bartolini <gabriele(dot)bartolini(at)2ndquadrant(dot)it>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Proposed patch: Smooth replication during VACUUM FULL |
| Date: | 2011-05-02 14:37:13 |
| Message-ID: | 21138.1304347033@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> I can't see the objection to replacing something inadvertently removed
> in 9.0, especially since it is a 1 line patch and is accompanied by
> copious technical evidence.
I am not sure which part of "this isn't a substitute for what happened
before 9.0" you fail to understand.
As for "copious technical evidence", I saw no evidence provided
whatsoever that this patch really did anything much to fix the
reported problem. Yeah, it would help during the initial scan
of the old rel, but not during the sort or reindex steps.
(And as for the thoroughness of the technical analysis, the patch
doesn't even catch the second CHECK_FOR_INTERRUPTS in copy_heap_data;
which would at least provide some relief for the sort part of the
problem, though only in the last pass of sorting.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Johann 'Myrkraverk' Oskarsson | 2011-05-02 14:41:21 | (Better) support for cross compiled external modules |
| Previous Message | David Fetter | 2011-05-02 13:58:37 | Re: HTML tags :/ |