From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgindent issue with EXEC_BACKEND-only typedefs |
Date: | 2007-12-17 16:06:14 |
Message-ID: | 21130.1197907574@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> I don't know how to make it output the symbol names like it seems to do
> for you.
I dislike the object-file-based approach altogether, not least because
it appears to depend on unportable aspects of someBSD's objdump.
Surely there's some code out there that can find typedef names from the
source files? Why does pgindent even need to be told this?
> I am also wondering if current GNU indent is now better suited to the
> task. Perhaps the bugs that it had on earlier versions have since been
> fixed? I remember checking the source code size a couple of years ago
> and it had grown by an order of magnitude or something like that.
It might be interesting to try it again. It's been quite a few years
since anyone tried it on the PG sources, AFAIK.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-12-17 16:27:09 | Re: ecxt_scantuple has wrong TupleDesc |
Previous Message | Alvaro Herrera | 2007-12-17 14:53:43 | Re: pgindent issue with EXEC_BACKEND-only typedefs |