| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> | 
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> | 
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> | 
| Subject: | Re: pgsql: Fix CommandCounterIncrement in partition-related DDL | 
| Date: | 2018-03-20 18:37:46 | 
| Message-ID: | 21120.1521571066@sss.pgh.pa.us | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers | 
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> I wonder about adding a syscache callback so that when an item in
> pg_partitioned_table is invalidated, the relcache entry for partrelid
> entry in pg_class is invalidated also.  I can't find any precedent for
> anything similar, though, and there doesn't seem to be any convenient
> place to do it, either.
In principle you could do it by adding logic to CacheInvalidateHeapTuple
in inval.c, similar to the existing logic for pg_class, pg_attribute
and pg_index entries.  Not sure it's worthwhile though.  That's very
ancient code; of late our practice has been to insist that the code
modifying other catalogs that feed into relcache entries should issue
a relcache inval explicitly.  If there's a reason why it's not convenient
to do that, then maybe making CacheInvalidateHeapTuple do it is a
good way.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-03-20 18:55:29 | Re: pgsql: Fix CommandCounterIncrement in partition-related DDL | 
| Previous Message | Alvaro Herrera | 2018-03-20 18:26:59 | Re: pgsql: Fix CommandCounterIncrement in partition-related DDL | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2018-03-20 18:41:15 | Re: [HACKERS] per-sesson errors after interrupting CLUSTER pg_attribute (not attrdef) | 
| Previous Message | Alvaro Herrera | 2018-03-20 18:26:59 | Re: pgsql: Fix CommandCounterIncrement in partition-related DDL |