Re: needlessly casting away const in localtime.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Mark Dilger <hornschnorter(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: needlessly casting away const in localtime.c
Date: 2016-09-20 21:13:30
Message-ID: 21101.1474406010@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Mark Dilger <hornschnorter(at)gmail(dot)com> writes:
> Friends, per the recent thread "gratuitous casting away const", the
> assignment on line 1247 of localtime.c has const lvalue and rvalue,
> yet casts through (char *) rather than (const char *). Fix attached.

If you want to propose cosmetic improvements in localtime.c, or the
majority of the other stuff in src/timezone, you need to send it to
the IANA folk. Otherwise it'll just be lost next time we sync with
them. See src/timezone/README.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2016-09-20 21:33:17 Re: gratuitous casting away const
Previous Message Mark Dilger 2016-09-20 21:02:34 needlessly casting away const in localtime.c