From: | Pavel Raiskup <praiskup(at)redhat(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Devrim GÜNDÜZ <devrim(at)gunduz(dot)org> |
Subject: | Re: plruby: rb_iterate symbol clash with libruby.so |
Date: | 2018-11-07 16:06:01 |
Message-ID: | 2108690.PGVSR67BWN@nb.usersys.redhat.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wednesday, November 7, 2018 4:55:13 PM CET Tom Lane wrote:
> Pavel Raiskup <praiskup(at)redhat(dot)com> writes:
> > On Wednesday, November 7, 2018 3:25:31 PM CET Tom Lane wrote:
> >> Yeah, I'm now mighty confused about this as well. PL/Ruby is pretty old
> >> too, so how come nobody noticed this before? Is its rb_iterate call in
> >> someplace that hardly gets any use?
>
> > ... I reproduced this by trigger function from tests/plt test-case
> > on the first try, more info and related fixes in [1]. But it is truth
> > that we haven't run the test-suite for RPM builds so far.
> > Might the reason be that nobody used plruby at all for a very long time?
>
> I'm starting to think that. I just browsed through the code of plruby,
> and while I don't know that language at all, there are rb_iterate calls
> in places that look like they'd be hard to avoid in typical use.
>
> The fact that the upstream git repo hasn't been touched in nine years
> doesn't exactly indicate a lively project, either :-(
>
> If you guys want to pursue this, I'll finish up the back-patch, but I
> wonder if we're just wasting our time.
FWIW, I plan to help with fixing the plruby project, but to be honest - I
still think that the code can be fixed to not use rb_iterate() anyways.
So back-patch is not needed by me - and certainly not now.
Pavel
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2018-11-07 16:09:13 | Re: [HACKERS] [PATCH] Generic type subscripting |
Previous Message | Robert Haas | 2018-11-07 16:05:07 | Re: ATTACH/DETACH PARTITION CONCURRENTLY |