Re: pg_upgrade test chatter

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: "Bossart, Nathan" <bossartn(at)amazon(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_upgrade test chatter
Date: 2021-10-20 02:08:52
Message-ID: 2097922.1634695732@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> On 2021-Oct-19, Tom Lane wrote:
>> We could dodge that, with modern versions of psql, by issuing
>> two -c switches.

> Isn't it easier to pass client_min_messages via PGOPTIONS?

> PGOPTIONS="-c client_min_messages=warning" psql -c "drop database if exists foo"

Yeah, my original thought had been to hack this at the test level.
However, I felt like it'd be worth adding this code because we could
apply it elsewhere in pg_regress.c to save several psql sessions
(and hence backend starts) per regression DB creation. That's not a
huge win, but it'd add up.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-10-20 02:37:28 Re: pg_upgrade test chatter
Previous Message Tom Lane 2021-10-20 02:04:51 Re: [RFC] building postgres with meson