| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-8.0 serve |
| Date: | 2016-10-12 18:56:29 |
| Message-ID: | 20952.1476298589@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 10/12/16 12:20 PM, Tom Lane wrote:
>> Remove pg_dump/pg_dumpall support for dumping from pre-8.0 servers.
> It looks like this or a related commit has caused these compiler warnings:
> pg_dump.c: In function 'getTypes':
> pg_dump.c:3692:8: error: variable 'i_typoutput' set but not used
> [-Werror=unused-but-set-variable]
> int i_typoutput;
> ^~~~~~~~~~~
> pg_dump.c:3691:8: error: variable 'i_typinput' set but not used
> [-Werror=unused-but-set-variable]
> int i_typinput;
> ^~~~~~~~~~
Ah, I'd not noticed because my compiler doesn't complain.
Will fix, thanks.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-10-12 19:11:37 | pgsql: pg_dump's getTypes() needn't retrieve typinput or typoutput anym |
| Previous Message | Tom Lane | 2016-10-12 18:54:25 | pgsql: Remove unnecessary int2vector-specific hash function and equalit |