Re: Small patch: fix double variable initializations in policy.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small patch: fix double variable initializations in policy.c
Date: 2016-03-17 20:50:09
Message-ID: 2090.1458247809@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> writes:
> I'm quite sure that there is no need to initialize these variables
> twice. First patch fixes this. Also I discovered that policy.c is not
> properly pgindent'ed. Second patch fixes this too.

Applied the first patch --- though I chose to do it the other way
(keep the declaration and assignment separate) because as you had it,
pgindent would've inserted an ugly/confusing blank line within the
declarations stanza of the block.

With the end of the devel cycle fast approaching, we might as well leave
it to the regular pgindent run to clean up the other issues. People tend
to complain if you invalidate pending patches at this time of year ;-)

Thanks for catching this!

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-03-17 20:53:17 Re: [PATCH] Supporting +-Infinity values by to_timestamp(float8)
Previous Message Joshua D. Drake 2016-03-17 20:41:22 Re: Make primnodes.h gender neutral