From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Greg Stark <stark(at)mit(dot)edu> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Subject: | Re: Re: [COMMITTERS] pgsql: Add some isolation tests for deadlock detection and resolution. |
Date: | 2016-02-13 15:16:14 |
Message-ID: | 20895.1455376574@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Greg Stark <stark(at)mit(dot)edu> writes:
> The tests worked fine on faster build animals, right? And the clobber
> animals are much much slower.... So it seems perfectly sensible that their
> deadlock timeout would just have to be much much higher to have the same
> behaviour. I see nothing wrong in just setting deadlock timeout to a minute
> or more on these machines.
We don't have a way to make the isolation tests change behavior depending
on how the backend is compiled. So the only actually available fix is to
make that test take "a minute or more" for *everybody*.
Aside from that, it's just disturbing that these tests aren't
deterministic regardless of machine speed. We don't seem to have a
way around that right now, but I wish we did.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-02-13 18:32:01 | Re: pgsql: Introduce group locking to prevent parallel processes from deadl |
Previous Message | Tom Lane | 2016-02-13 14:54:07 | Re: [COMMITTERS] pgsql: Code cleanup in the wake of recent LWLock refactoring. |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2016-02-13 15:16:53 | Re: Defaults for replication/backup |
Previous Message | Joshua D. Drake | 2016-02-13 15:13:55 | Re: Defaults for replication/backup |