Re: Remove readline notice from psql --version?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove readline notice from psql --version?
Date: 2012-05-20 16:30:13
Message-ID: 20861.1337531413@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Currently, psql --version prints something like
> psql (PostgreSQL) 9.2beta1
> contains support for command-line editing

> I think the notice about readline is a leftover from the old days when
> psql was often built without any readline support. Nowadays, this looks
> like an anomaly, and it doesn't actually contain any information that
> would be useful nowadays, such as which particular library is used or
> what kind of history support is active. I suggest we remove this second
> line, or alternatively, we could add more useful detail, but what?

Hm, I had actually forgotten that was there. When the question of
"which readline library does this use?" has come up in the past,
we've always been able to get an answer from ldd or local equivalent.
I suppose that could fail in the case of statically linked libraries,
but the practical use for the message seems about nil. I'm good with
just removing it.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2012-05-20 18:12:07 Re: read() returns ERANGE in Mac OS X
Previous Message Tom Lane 2012-05-20 15:28:25 Re: weird error message in sepgsql