Re: Patch for Makefile race against current cvs

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Klaus Naumann <knaumann(at)gmx-ag(dot)de>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Patch for Makefile race against current cvs
Date: 2001-11-09 18:06:05
Message-ID: 20830.1005329165@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Klaus Naumann <knaumann(at)gmx-ag(dot)de> writes:
> Also even if it would be make's fault I don't see what my patch makes
> worse. But if you don't want to apply it, you don't apply it.

Well, as to whether it gets applied or not, I'll defer to Peter
Eisentraut who has done most of the work recently on our configure and
make support. The reason I'm asking all these questions is that I
want to understand what the problem really is. It seems to me that if
we have a problem with these bison invocations then we are likely to
have similar problems elsewhere. We need to understand why it's
unsafe and what the general rule is for avoiding such mistakes in
future.

What bothers me is that you seem to be saying that *any* construct
involving multiple outputs from one rule is unsafe in a parallel make.
That strikes me as a huge restriction, and one that would surely be
mentioned prominently in the gmake manual if it were real. But I can't
find anything that says that.

I think what you are looking at here is a gmake bug, and that you should
report it to the gmake people.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2001-11-09 18:07:00 Re: Patch for Makefile race against current cvs
Previous Message Tom Lane 2001-11-09 17:46:16 Re: Enhanced index details using \d in psql