Re: fix log_min_duration_statement logic error

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix log_min_duration_statement logic error
Date: 2003-10-04 18:33:09
Message-ID: 20775.1065292389@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Bruce Momjian writes:
>> LOG: duration(secs): 0.000257
>> LOG: duration(secs): 0.000754
>> LOG: duration(secs): 0.008115 select * from pg_class;

> I think the units typically go after the number.

In any case, this is unnecessarily incompatible with everything else.
EXPLAIN and psql's \timing show query durations in milliseconds. And
isn't log_min_duration_statement itself measured in milliseconds?

I would prefer to see the log entries look like

LOG: query: select * from pg_class;
LOG: duration: nn.nnn msec

in all cases, rather than moving information around depending on which
combination of switches happens to have caused the log entries to be
generated. Am willing to fix the code to make this happen.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2003-10-04 19:25:34 Re: more spanish updates
Previous Message Peter Eisentraut 2003-10-04 18:14:09 Re: fix log_min_duration_statement logic error