| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | lalbin(at)fhcrc(dot)org, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #8257: Multi-Core Restore fails when containing index comments |
| Date: | 2013-06-27 14:29:14 |
| Message-ID: | 20760.1372343354@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> The problem is that pg_dump makes the comment depend on the index
> instead of the constraint:
Yeah, I figured that out yesterday, but hadn't gotten to writing a patch
yet.
> ... So what we need
> to do is to make the comment depend on the constraint instead.
Your proposed patch will only fix the problem for dumps created after
it ships. In the past, we've tried to deal with this type of issue by
having pg_restore fix up the dependencies when reading a dump, so that
it would still work on existing dumps.
I'm afraid there may be no way to do that in this case --- it doesn't
look like there's enough info in the dump to tell where the dependency
link should have led. But we should think about it a little before
taking the easy way out.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2013-06-27 14:43:15 | Re: BUG #8257: Multi-Core Restore fails when containing index comments |
| Previous Message | varunkarkala | 2013-06-27 12:23:00 | BUG #8259: Not able to search composite type in search object |