Re: [HACKERS] PGXLOG variable worthwhile?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Marc G(dot) Fournier" <scrappy(at)hub(dot)org>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Dave Page <dpage(at)vale-housing(dot)co(dot)uk>, Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, shridhar_daithankar(at)persistent(dot)co(dot)in, Pgsql-hackers(at)postgresql(dot)org, Pgsql-general(at)postgresql(dot)org
Subject: Re: [HACKERS] PGXLOG variable worthwhile?
Date: 2002-09-19 03:25:40
Message-ID: 20671.1032405940@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

"Marc G. Fournier" <scrappy(at)hub(dot)org> writes:
> On Wed, 18 Sep 2002, Bruce Momjian wrote:
>> Sorry, I don't see the logic here. Using postgresql.conf, you set it
>> once and it remains set until you change it again. With -X, you have to
>> use it every time. I think that's where the votes came from.

> Ah, so you are saying that you type out your full command line each and
> every time you start up the server?

Let's put it this way: would you be in favor of adding a
--please-don't-wipe-my-database-directory
switch to the postmaster? And if you forget to specify that every time
you start the postmaster, we do an instant "rm -rf $PGDATA"?

Doesn't seem like a good idea, does it?

Well, specifying the XLOG location on the command line or as an
environment variable is just about as deadly as the above loaded-gun-
pointed-at-foot scenario. You start the postmaster with the wrong
context, even once, it's sayonara to your data integrity.

The point of insisting that the XLOG location be recorded *inside*
the data directory is to prevent simple admin errors from being
catastrophic. Do you remember when we regularly saw trouble reports
from people who'd corrupted their database indexes by starting the
postmaster with different LOCALE environments at different times? We
fixed that by forcing the locale collation order to be specified inside
the database directory (in pg_control, but the details are not important
here), rather than allowing it to be taken from postmaster environment.

If we allow XLOG location to be determined by a postmaster switch or
environment variable, then we *will* be opening the door for people
to shoot themselves in the foot just like they used to do with locale.

I learned something from those problems, and I do not intend to make
the same mistake again.

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2002-09-19 03:34:40 Re: Permissions with multiple groups...
Previous Message Bill Gribble 2002-09-19 03:07:35 Re: IN vs EXIIST

Browse pgsql-hackers by date

  From Date Subject
Next Message Neil Conway 2002-09-19 03:29:38 Re: Beta2 on Friday Morning (Was: Re: Open 7.3 items)
Previous Message Tom Lane 2002-09-19 03:14:20 Re: The TODO List (Was: Re: Open 7.3 items)