Re: More vacuum stats

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Greg Smith <greg(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: More vacuum stats
Date: 2010-08-23 14:38:44
Message-ID: 20630.1282574324@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Mon, Aug 23, 2010 at 16:28, Greg Smith <greg(at)2ndquadrant(dot)com> wrote:
>> What I actually want here is for the time that the last table autovacuum
>> started, adding to the finish time currently exposed by pg_stat_user_tables.

> Now, that would be quite useful. That'd require another stats message,
> since we don't send anything on autovacuum start, but I don't think
> the overhead of that is anything we need to worry about - in
> comparison to an actual vacuum...

No, you wouldn't really need an extra message, you could just send both
start and finish times in the completion message. I'm not sure that
having last start time update before last end time would be a good idea
anyway.

But in any case it's true that an extra message wouldn't be a
significant cost. What I'd be more concerned about is the stats table
bloat from adding yet another per-table field. That could be a lot of
space on an installation with lots of tables.

> We could also store last_autovacuum_vacuum_duration - is that better
> or worse than start and end time?

No, I think you want to know the actual time not only the duration.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2010-08-23 14:40:46 Re: More vacuum stats
Previous Message Magnus Hagander 2010-08-23 14:32:21 Re: More vacuum stats