Re: Strange path from pgarch_readyXlog()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Strange path from pgarch_readyXlog()
Date: 2021-12-29 21:04:12
Message-ID: 2061330.1640811852@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Bossart, Nathan" <bossartn(at)amazon(dot)com> writes:
> I bet this was a simple mistake in beb4e9b.

> -static char arch_filenames[NUM_FILES_PER_DIRECTORY_SCAN][MAX_XFN_CHARS];
> +static char arch_filenames[NUM_FILES_PER_DIRECTORY_SCAN][MAX_XFN_CHARS + 1];

Hm, yeah, that looks like a pretty obvious bug.

While we're here, I wonder if we ought to get rid of the static-ness of
these arrays. I realize that they're only eating a few kB, but they're
doing so in every postgres process, when they'll only be used in the
archiver.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message SATYANARAYANA NARLAPURAM 2021-12-29 21:23:49 Logging replication state changes
Previous Message Bossart, Nathan 2021-12-29 20:50:56 Re: Strange path from pgarch_readyXlog()