From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Fujii Masao <fujii(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Include information on buffer usage during planning phase, in EX |
Date: | 2020-04-03 13:35:33 |
Message-ID: | 20577.1585920933@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
> On 2020/04/03 12:30, Tom Lane wrote:
>> so probably the thing to do is adapt
>> the filter functions in explain.sql so that they suppress Buffers lines
>> altogether in text output. Kind of annoying, but ...
> I'm thinking to suppress only Buffers line just after Planning Time line,
> by applying something like the following changes to explain_filter().
> Thought?
I think this is a bad idea. It's overcomplicated, and more to the
point: now that we've seen the problem we should realize that we're
eventually going to have failures for *any* Buffers line in text-mode
output. We're already filtering them so hard as to be nearly useless
(see a couple lines further down). I think we should just drop them
in text mode and be content with checking for them in non-text modes.
Robert's muttered about possibly introducing some EXPLAIN option
that would make the output a bit less variable. Perhaps we should
do that. I'm not quite sure I like the idea on theoretical grounds:
testing a different behavior from what you do in production seems
like the wrong thing. But it'd allow undoing decisions like this one.
It's too late to consider such a thing for v13, though --- four days
before feature freeze is no time to be designing new features.
So for now, we have to make the output stable with the tools we have,
and text-mode Buffers output is unstable by design.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2020-04-03 14:28:59 | Re: pgsql: Include information on buffer usage during planning phase, in EX |
Previous Message | Julien Rouhaud | 2020-04-03 12:49:43 | Re: pgsql: Include information on buffer usage during planning phase, in EX |