Re: Duplicate code in psql's \ commands

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Duplicate code in psql's \ commands
Date: 2009-04-19 18:09:48
Message-ID: 20532.1240164588@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Fetter <david(at)fetter(dot)org> writes:
> While working on the new improved \df, I noticed a pretty major
> infelicity, namely that \ commands get validated by two completely
> independent code paths, namely tab-complete.c and
> command.c/describe.c.

Why is tab-complete doing anything that could be described as validation?

> I'm thinking it would be a good idea to factor the validating out as
> far as possible. This would also make it easier to make sure that tab
> completion and \'s output match to the maximal reasonable extent.

I rather doubt that this will really be much of a win, but if you want
to try it as a separate patch, go ahead.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2009-04-19 18:20:49 Re: Duplicate code in psql's \ commands
Previous Message Pavel Stehule 2009-04-19 17:47:37 Re: Patch for 8.5, transformationHook