Re: init_htab causes SIGFPE (or worse) due to miscalculation for large nbuckets

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: init_htab causes SIGFPE (or worse) due to miscalculation for large nbuckets
Date: 2012-12-11 02:19:07
Message-ID: 2050.1355192347@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> On Mon, 2012-12-10 at 20:27 -0500, Tom Lane wrote:
>> That does seem like a good idea. We need one for an int-sized result
>> too, to fix the original problem in init_htab. So I propose these
>> functions:

> Looks good to me. One other corner case in the version of the patch I
> was working on was that nbuckets is compared to num_partitions, which is
> a long. We can assert that it is less than or equal to INT_MAX in
> hash_create.

> Aside from that, I'll drop my version of the patch, which doesn't have
> any useful differences from yours.

I hadn't gone any further than to code and test the functions I listed.
If you are working on a complete patch, please press on.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Jeff Davis 2012-12-11 03:45:44 Re: init_htab causes SIGFPE (or worse) due to miscalculation for large nbuckets
Previous Message Jeff Davis 2012-12-11 02:05:49 Re: init_htab causes SIGFPE (or worse) due to miscalculation for large nbuckets