| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | "Shulgin, Oleksandr" <oleksandr(dot)shulgin(at)zalando(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Trivial fixes for some IDENTIFICATION comment lines |
| Date: | 2016-01-18 17:01:02 |
| Message-ID: | 20470.1453136462@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2016-01-18 12:52:06 +0100, Shulgin, Oleksandr wrote:
>> I've noticed that in src/backend/replication/logical/reorderbuffer.c, the
>> IDENTIFICATION comment line is incorrect:
>>
>> * IDENTIFICATION
>> - * src/backend/catalog/dropcmds.c
>> - * src/backend/replication/logicalfuncs.c
>> - * src/backend/replication/reorderbuffer.c
>> - * src/backend/replication/snapbuild.c
>> - * src/backend/storage/ipc/dsm.c
>> - * src/backend/utils/cache/relfilenode.c
>> - * src/backend/utils/cache/evtcache.c
> How about we simply drop them instead alltogether? This isn't exactly a
> seldomly made mistake, and they seem to actually contribute very little
> value?
Personally I think they're of some value. Particularly with stuff like
Makefiles, which are otherwise confusingly similar.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2016-01-18 17:03:03 | Re: Combining Aggregates |
| Previous Message | Thom Brown | 2016-01-18 16:52:42 | Re: Support for N synchronous standby servers - take 2 |