From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
Cc: | Euler Taveira <euler(at)eulerto(dot)com>, coleman(dot)rik(at)gmail(dot)com, pgsql-docs(at)lists(dot)postgresql(dot)org |
Subject: | Re: 52.88. pg_shmem_allocations, missing units |
Date: | 2022-08-15 11:27:58 |
Message-ID: | 2045FB3A-3679-47BD-97C8-3D8283A14724@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs |
> On 15 Aug 2022, at 04:23, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Mon, Aug 15, 2022 at 3:56 AM Euler Taveira <euler(at)eulerto(dot)com> wrote:
>>
>> On Fri, Aug 12, 2022, at 5:43 PM, PG Doc comments form wrote:
>>
>> Could someone add the units of size & allocated_size on the documentation
>> for pg_shmem_allocations? Currently there aren't any listed.
>>
>> According to ShmemIndexEnt struct:
>>
>> /* this is a hash bucket in the shmem index table */
>> typedef struct
>> {
>> char key[SHMEM_INDEX_KEYSIZE]; /* string name */
>> void *location; /* location in shared mem */
>> Size size; /* # bytes requested for the structure */
>> Size allocated_size; /* # bytes actually allocated */
>> } ShmemIndexEnt;
>>
>> The unit is bytes. A patch is attached to add such information.
>
> +1
>
> The patch looks good to me.
Agreed, and adding the unit matches how other system views attributes like
pg_stat.avg_width. Will apply it in a bit.
--
Daniel Gustafsson https://vmware.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Tatsuo Ishii | 2022-08-16 00:40:43 | Re: Only one nextval tag is different |
Previous Message | Masahiko Sawada | 2022-08-15 02:23:02 | Re: 52.88. pg_shmem_allocations, missing units |