| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Julian Markwort <julian(dot)markwort(at)uni-muenster(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, marius(dot)timmer(at)uni-muenster(dot)de, arne(dot)scheffer(at)uni-muenster(dot)de |
| Subject: | Re: [HACKERS] [FEATURE PATCH] pg_stat_statements with plans (v02) |
| Date: | 2018-03-02 19:55:28 |
| Message-ID: | 20369.1520020528@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> Yea, I misread the diff to think you added a conflicting version. Due
> to:
> -DATA =3D pg_stat_statements--1.4.sql pg_stat_statements--1.4--1.5.sql \
> +DATA =3D pg_stat_statements--1.5.sql pg_stat_statements--1.4--1.5.sql \
> and I'd checked that 1.5 already exists. But you just renamed the file,
> presumably because it's essentially rewriting the whole file? I'm not
> sure I'm a big fan of doing so, because that makes testing the upgrade
> path more work.
Yeah, that is not project style anymore. Just add a delta file and leave
it at that. See e.g. de1d042f5979bc1388e9a6d52a4d445342b04932 for an
example.
(We might from time to time roll up the deltas and replace the base
file with a newer version, but I think that should happen in separate
housekeeping commits.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julian Markwort | 2018-03-02 19:55:49 | Re: [HACKERS] [FEATURE PATCH] pg_stat_statements with plans (v02) |
| Previous Message | Andres Freund | 2018-03-02 19:54:42 | Re: 2018-03 Commitfest Summary (Andres #1) |