Re: [HACKERS] Enhanced containment selectivity function

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Matteo Beccati <php(at)beccati(dot)com>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Enhanced containment selectivity function
Date: 2006-04-26 19:12:46
Message-ID: 20368.1146078766@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Cleaned-up patch attached and applied.

Please revert this patch. This has not been updated to satisfy the
previous agreement about how it should work. It is completely
inappropriate to be dropping code that's specific to one contrib module
into the core selfuncs.c file. What we had agreed to do was look at
exporting some of the currently-static functions in selfuncs.c so that
contrib modules could make use of them from outside the core --- but
this patch doesn't do that.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2006-04-26 20:26:53 Re: [HACKERS] Enhanced containment selectivity function
Previous Message Tom Lane 2006-04-26 19:04:51 Re: Regarding TODO item "%Add a separate TRUNCATE permission"

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-04-26 20:26:53 Re: [HACKERS] Enhanced containment selectivity function
Previous Message Bruce Momjian 2006-04-26 18:33:09 Re: [HACKERS] Enhanced containment selectivity function