From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: WIP: pushing parser hooks through SPI and plancache |
Date: | 2009-11-04 20:05:23 |
Message-ID: | 20307.1257365123@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Tom Lane wrote:
>> ... For the moment I've worked
>> around this by putting the typedef into nodes/params.h itself, but I
>> can't say I find that a pleasing solution. Has anyone got a better
>> idea? Should we make a parser/something header that just provides that
>> typedef?
> Hmm ... if you create the new include file, is that going to avoid
> having to include params.h in plancache.h?
Well, it'd include the new file instead of params.h.
> If not, I don't think there's much point in having a new file (other
> than the typedef just not fitting in params.h).
Yeah, what's bothering me is that it just doesn't fit there --- doesn't
seem to satisfy the POLA. But I guess there are plenty of bigger
issues than that in our code base.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-11-04 20:21:30 | Re: "ERROR: could not read block 6 ...: read only 0 of 8192 bytes" after autovacuum cancelled |
Previous Message | Alvaro Herrera | 2009-11-04 18:34:03 | "ERROR: could not read block 6 ...: read only 0 of 8192 bytes" after autovacuum cancelled |