Re: doc: modify the comment in function libpqrcv_check_conninfo()

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, ikedarintarof <ikedarintarof(at)oss(dot)nttdata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: doc: modify the comment in function libpqrcv_check_conninfo()
Date: 2024-07-08 06:28:04
Message-ID: 202ec279-c307-48b9-9920-730fb1221d27@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2024/07/01 18:15, Jelte Fennema-Nio wrote:
> On Thu, 27 Jun 2024 at 12:27, ikedarintarof
> <ikedarintarof(at)oss(dot)nttdata(dot)com> wrote:
>> Thanks for your suggestion. I used ChatGPT to choose the wording, but
>> it's still difficult for me.
>
> Looks good to me now (but obviously biased since you took my wording).

LGTM, too.

* Validate connection info string, and determine whether it might cause
* local filesystem access to be attempted.

The later part of the above comment for libpqrcv_check_conninfo()
seems unclear. My understanding is that if must_use_password is true
and this function completes without error, the password must be
in the connection string, so there's no need to read the .pgpass file
(i.e., no local filesystem access). That part seems to be trying to
explaing something like that. Is this correct?

Anyway, wouldn't it be better to either remove this unclear part or
rephrase it for clarity?

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2024-07-08 06:39:56 Re: Pluggable cumulative statistics
Previous Message Bertrand Drouvot 2024-07-08 06:19:54 Re: walsender.c comment with no context is hard to understand