From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: archive_command failures report confusing exit status |
Date: | 2007-12-10 22:02:05 |
Message-ID: | 20297.1197324125@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Peter Eisentraut wrote:
>> I figured it would make sense if pgarch.c used the same mechanism that
>> postmaster.c uses to report the various variants of regular and signal
>> exits.
> Hmm. Getting rid of the "(PID 0)" is going to be a mess enough for
> translations that I think it is worth pgarch.c having its own routine
> for this. Furthermore I think the detailed archive command should be
> reported in an errdetail() field, which makes it even farther off.
I agree with Alvaro --- trying to make LogChildExit serve two masters
will be uglier and less maintainable than having two copies of the
not-really-so-complex logic involved. Leave postmaster.c alone and
just make pgarch.c smarter.
(But having said that, +1 for improving the message.)
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-12-10 22:05:28 | Re: Problem of a server gettext message. |
Previous Message | Obe, Regina | 2007-12-10 21:52:14 | Re: Script to reset all sequence values in the a given DB? |